Closed
Bug 811345
Opened 12 years ago
Closed 12 years ago
[desktop] Headers 'n' Footers
Categories
(Marketplace Graveyard :: Consumer Pages, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
2013-01-17
People
(Reporter: clouserw, Assigned: cvan)
References
Details
Attachments
(9 files, 1 obsolete file)
UX has delivered new headers and footers for the desktop site. Attached are jpgs and psds. Please direct questions to mhanratty or mushi.
Reporter | ||
Updated•12 years ago
|
Attachment #681081 -
Attachment description: header mock → footer mock
Reporter | ||
Comment 1•12 years ago
|
||
Reporter | ||
Comment 2•12 years ago
|
||
Assets are too large to attach. Let me know if this link doesn't work http://cl.ly/3i2A1H3u2y3E
Comment 4•12 years ago
|
||
"Support" has been added to the extended footer. https://www.dropbox.com/s/kw3lz01bxicdp33/Marketplace-%28Desktop%29-i01-Footers_v2_mm.psd
Assignee | ||
Updated•12 years ago
|
Target Milestone: 2012-11-22 → 2012-11-29
Assignee | ||
Comment 6•12 years ago
|
||
https://github.com/mozilla/zamboni/commit/be78a93 https://github.com/mozilla/zamboni/commit/f4d23fe
Assignee | ||
Updated•12 years ago
|
Summary: [desktop] Headers n' Footers → [desktop] Headers 'n' Footers
Assignee | ||
Updated•12 years ago
|
Target Milestone: 2012-11-29 → 2012-12-06
Assignee | ||
Comment 7•12 years ago
|
||
(In reply to Michael Maslaney from comment #4) > "Support" has been added to the extended footer. Where should this link to?
Comment 8•12 years ago
|
||
Support link should direct here (same as "Get Help" on the "Feedback" screen) https://support.mozilla.org/en-US/products/marketplace
Assignee | ||
Comment 9•12 years ago
|
||
https://github.com/mozilla/zamboni/commit/b89cdeb What's left before I close this bug? * drop-down menu * blue gear icon on :hover * retina gears * retina magnifying glass (with smaller text) Outside the scope of this bug, but worth addressing: * breadcrumbs (bug TBD) * buttons for search filters (bug 811356)
Assignee | ||
Comment 10•12 years ago
|
||
Added drop-down menu with updated gear icons: https://github.com/mozilla/zamboni/commit/e36193f What's left? New search icon - and that's all, I swear.
Comment 11•12 years ago
|
||
Chris, do you need a retina optimized graphic for the "Search Icon"?
Assignee | ||
Comment 12•12 years ago
|
||
https://github.com/mozilla/zamboni/commit/6fee38c (In reply to Michael Maslaney from comment #11) > Chris, do you need a retina optimized graphic for the "Search Icon"? Nope, I got it from the .PSD. Thanks!
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: 2012-12-06 → 2012-12-13
Comment 13•12 years ago
|
||
Michael--is this how you intend the footer to look, i.e. the Mozilla footer makes up for the extra space, for a screen with little content?
Comment 14•12 years ago
|
||
Yes it is, Maureen.
Comment 15•12 years ago
|
||
Chris, A couple of comments for the Dev Hub Footer Rocket Icon • Drop shadows should be set to 90°. Currently their coming from the upper left side. • Adjust the space between the rocket and the headline to 17px or it's equivalent. Header • "Develop Apps for Marketplace should have a typographic measure of 22px/30px (size/line-height) • "Visit the Developer Hub" should have a typographic measure of 14px/48px Background • Shading is off (too dark) and the shading is beveled instead of raised, please refer to the comps for reference • Center the vertical divider between the header and navigation • The top and bottom rules for the footer are off (making it look beveled, instead of raised), the top is missing a highlight and the bottom is missing a shadow.
Comment 16•12 years ago
|
||
Comment 17•12 years ago
|
||
Comment 18•12 years ago
|
||
CORRECTION: "Visit the Developer Hub" should have a typographic measure of 14px/30px*
Assignee | ||
Comment 19•12 years ago
|
||
The spacing and the width will be addressed when we move our desktop layouts to a width of 768px. We're currently keeping it at 600px until bug 811350 is completed so as to not regress the site during our weekly pushes. Many thanks for the comments, and I'll be addressing them immediately!
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 20•12 years ago
|
||
(In reply to Michael Maslaney from comment #18) > CORRECTION: > > "Visit the Developer Hub" should have a typographic measure of 14px/30px* Changing to those measurements shows this: http://f.cl.ly/items/25140i3b1x190p0v361o/Screen%20Shot%202012-12-10%20at%2012.26.39%20PM.png
Comment 21•12 years ago
|
||
Chris, The leading (line-height) looks good, thank you. Questions: • is "Visit the Developer Hub" font-size 14px? It looks like the same size as the header, which should be 22px. • I had to make a line break in the header because of the limited space available for the admin footer. Are we still accommodating this screen? • If we are able to set the header to one line, could we vertically center the text with the rocket icon Thanks, again.
Assignee | ||
Comment 22•12 years ago
|
||
(In reply to Michael Maslaney from comment #21) > Chris, > > The leading (line-height) looks good, thank you. > > Questions: > > • is "Visit the Developer Hub" font-size 14px? It looks like the same size > as the > header, which should be 22px. font-size/line-height: 14px/30px http://f.cl.ly/items/3C062G240F1X2Y0R2t0J/Screen%20Shot%202012-12-14%20at%2010.35.15%20AM.png 20px/26px http://f.cl.ly/items/1g3s243O2o1V3g46092b/Screen%20Shot%202012-12-14%20at%2010.35.43%20AM.png Which looks closer to what we want? > • If we are able to set the header to one line, could we vertically center > the text > with the rocket icon We are, yep.
Comment 23•12 years ago
|
||
Chris could we do this: "Develop Apps for Marketplace" font-size: 22px; line-height: 30px "visit developer hub" font-size: 14px; line-height: 30px Could we also remove the underline from the link? Not sure if this is a branding requirement
Assignee | ||
Comment 24•12 years ago
|
||
Thanks, Michael! Addressed comments above, including font-size/line-height changes: https://github.com/mozilla/zamboni/commit/2a88f30 https://marketplace-dev.allizom.org (In reply to Michael Maslaney from comment #15) > Rocket Icon > > • Drop shadows should be set to 90°. Currently their coming from the upper > left side. That's a straight conversion of the rocket icon directly from the PSDs: https://github.com/mozilla/zamboni-psds/blob/master/media/img/mkt/icons/rocket.psd https://github.com/mozilla/zamboni-psds/blob/master/media/img/mkt/icons/rocket-2x.psd I tried re-exporting them, but they ended up looking the same. Wonder what I'm doing wrongly? > Background > > • Center the vertical divider between the header and navigation I'm not sure where - what do you mean?
Assignee | ||
Updated•12 years ago
|
Target Milestone: 2012-12-13 → 2012-12-20
Assignee | ||
Updated•12 years ago
|
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Comment 25•12 years ago
|
||
Chris, Couple updates: • Attached, updated Rocket Icon the dev footer. • Updated color background (attached a screen shot for reference) Main Background Gray: url("../../img/mkt/grain.png?d99a08c") repeat scroll 0% 0% rgb(208, 213, 217); Dev Footer Background Gray and top rule: border-top: 1px solid rgb(183, 183, 183); url("../../img/mkt/grain.png?d99a08c") repeat scroll 0% 0% rgb(216, 220, 224); • Providing links to the updated category icons and their tile backgrounds Icons: https://www.dropbox.com/s/soe4xp2h9mc8sch/marketplace-icons-singles.psd Icon Background Tiles: https://www.dropbox.com/s/d7pi6ky04t8fvmx/Marketplace-%28Desktop%29-i01-Home_v2_mm.psd Let me know if you need additional assets for the Category section.
Comment 26•12 years ago
|
||
Comment 27•12 years ago
|
||
Comment 28•12 years ago
|
||
Assignee | ||
Comment 29•12 years ago
|
||
Reopening to address comment 25 next week.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 2012-12-20 → 2013-01-17
Assignee | ||
Comment 30•12 years ago
|
||
https://github.com/mozilla/zamboni/commit/f1444be You can view the changes at https://marketplace-dev.allizom.org Michael: thanks for your new icons, your help, and your continued patience! (:
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•